On Tue, 31 Oct 2023 04:23:13 GMT, Jonathan Joo <j...@openjdk.org> wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Replace NULL with nullptr

Sorry for being a bit late to this PR. I think the addition of CPU time 
tracking is good, but I wonder if we could do it in a way that is a bit more 
general. A more general way of tracking CPU time for a set of threads and we 
could then have different consumers of this data. In addition to hsperf 
counters I think having logging and JFR events for this could be interesting as 
well. 

Have you had any thought along those lines, any obvious problems with such 
approach?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15082#issuecomment-1788665727

Reply via email to