On Mon, 30 Oct 2023 08:46:08 GMT, Taizo Kurashige <d...@openjdk.org> wrote:
> Hi, > > I fixed the typos for JFR.start and JFR.dump. > Acconding to issue's description, there is some typo in JFR.stop > documentation, but I couldn't find that. I confirmed that there is no such > typo in this repository. So I thought there was no need to fix JFR.stop > documentation. > > I confirmed that the fixes are reflected and that all of the jdk_jfr tests > pass. > > Could someone please review it? Changes requested by dholmes (Reviewer). src/jdk.jcmd/share/man/jcmd.1 line 1: > 1: .\" Copyright (c) 2012, 2023, Oracle and/or its affiliates. All rights > reserved. This file is generated from markdown sources that Oracle has to maintain. Please work with an Oracle engineer to get the changes applied to that source and then regenerate the `jcmd.1` nroff file. You can split this into a separate sub-task if needed. ------------- PR Review: https://git.openjdk.org/jdk/pull/16413#pullrequestreview-1705181772 PR Review Comment: https://git.openjdk.org/jdk/pull/16413#discussion_r1376871765
