On Tue, 24 Oct 2023 10:48:01 GMT, Afshin Zafari <azaf...@openjdk.org> wrote:
>> The `find` method now is
>> ```C++
>> template<typename T>
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and
>> Windows passed.
>
> Afshin Zafari has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains seven commits:
>
> - Merge remote-tracking branch 'upstream/master' into _8314502
> - first arg of `find` casted to `uint*`
> - Merge branch 'master' into _8314502
> - changed the `E` param of find methods to `const E&`.
> - find_from_end and its caller are also updated.
> - 8314502: Change the comparator taking version of GrowableArray::find to be
> a template method
> - 8314502: GrowableArray: Make find with comparator take template
I would prefer the function template with a unary predicate approach suggested
earlier
by multiple commenters. Is there a reason not to just do that?
-------------
Changes requested by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15418#pullrequestreview-1702913003
