On Thu, 19 Oct 2023 20:06:50 GMT, Johan Sjölen <jsjo...@openjdk.org> wrote:
> I think that NMT is deserving of its own subdirectory. Can we do a review of > the changes before I fix the merge conflicts? > > 1. Moved all the nmt source code from services/ to nmt/ > 2. Renamed all the include statements and sorted them > 3. Fixed the include guards Mostly okay. Was overdue. Don't need another look if you fix Davids and Stefan's remarks. test/hotspot/gtest/nmt/test_nmt_locationprinting.cpp line 30: > 28: #include "nmt/mallocHeader.inline.hpp" > 29: #include "runtime/os.hpp" > 30: #include "nmt/memTracker.hpp" order ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16276#pullrequestreview-1689369969 PR Review Comment: https://git.openjdk.org/jdk/pull/16276#discussion_r1366556167
