On Mon, 16 Oct 2023 19:07:37 GMT, Johannes Bechberger <jbechber...@openjdk.org>
wrote:
>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>>
>> This prevents `jdb` from receiving a broken exception event and throwing an
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Johannes Bechberger has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Fixed event location
Overall the changes look good except one minor comment typo I noted. I'd like
to first run this through our CI testing to make sure there are no issues.
test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 91:
> 89: if
> (!ex.location().equals(ex.thread().frame(0).location())) {
> 90: throw new RuntimeException(
> 91: String.format("Throw location %s and
> location if first frame %s are not equal",
Suggestion:
String.format("Throw location %s and
location of first frame %s are not equal",
-------------
PR Review: https://git.openjdk.org/jdk/pull/16145#pullrequestreview-1680940159
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1361253082
