On Thu, 24 Aug 2023 21:38:41 GMT, Kevin Walls <kev...@openjdk.org> wrote:
>> Several tests from test/jdk/sun/tools/jstatd are intermittent. >> >> Port clashes when run at the same time on the same machine have been a >> problem. >> The RMI error "no such object in table" can mean a reference on the RMI >> server has been GC'd. >> Either way, jstatd fails to startup and and the test fails. >> >> These both have jstatd reporting "Could not bind" which should be recognised >> and retried, as we already do for (some) port in use problems. i.e. >> JstatdTest.java: the isJstadReady() method (will correct that typo also) >> checks for "Port already in use", which can be printed by TCPTransport.java. >> >> Should update its test to check for "Could not bind". >> Should limit the retries also. > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Modernisation Good fix. Thanks, Serguei ------------- Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/15414#pullrequestreview-1599655246
