On Wed, 23 Aug 2023 06:45:25 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert _destroyed back to bool
>
> src/hotspot/share/runtime/vmStructs.hpp line 211:
>
>> 209: // e.g.: "static ObjectMonitor * volatile g_block_list;"
>> 210: #define CHECK_VOLATILE_STATIC_VM_STRUCT_ENTRY(typeName, fieldName,
>> type) \
>> 211: {type volatile * dummy = &typeName::fieldName; }
>
> It is not clear why the `PTR_` suffix is removed from the name.
The intent was to generalize it but the comments also need changing, and now
I'm not clear what this is actually doing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15373#discussion_r1302592273
