On Sat, 12 Aug 2023 03:56:05 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> VMConnection.open() expects launchTarget(), attachTarget(), and > listentTarget() to either throw an exception or return a valid VirtualMachine > instance. Instead they were catching certain exceptions and returning null, > which resulted in an NPE in VMConnection.open(). I've fixed it so these APIs > now rethrow any caught exception and never return null. > > Tested with tier1 and also running the following 10x each on linux-x64, > macosx-aarch64, and windows-x64: > > test/hotspot/jtreg/vmTestbase/nsk/jdwp/ > test/hotspot/jtreg/vmTestbase/nsk/jdb/ > test/hotspot/jtreg/vmTestbase/nsk/jdi > test/jdk/com/sun/jdi This pull request has now been integrated. Changeset: 388dcff7 Author: Chris Plummer <cjplum...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/388dcff72518c96a15e38ff0b18be8a89836c2d5 Stats: 21 lines in 2 files changed: 14 ins; 6 del; 1 mod 8282712: VMConnection.open() does not detect if VM failed to be created, resulting in NPE Reviewed-by: sspitsyn, amenkov ------------- PR: https://git.openjdk.org/jdk/pull/15255
