On Fri, 4 Aug 2023 14:37:07 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> This patch fixes Wconversion in code in the src/hotspot/share/prims
> directory. Most of the changes correct the types. jfieldID's are created
> with the int offset returned by InstanceKlass::field_offset().
> int field_offset (int index) const { return
> field(index).offset(); }
>
> So when we get the field offset back, it's an int.
>
> Also stackwalker passes jlong, so made that consistent.
>
> Tested with tier1 on Oracle supported platforms.
src/hotspot/share/prims/jni.cpp line 209:
> 207:
> 208:
> 209: intptr_t jfieldIDWorkaround::encode_klass_hash(Klass* k, intptr_t
> offset) {
The caller always passes an int, so why not change the parameter to int?
Suggestion:
intptr_t jfieldIDWorkaround::encode_klass_hash(Klass* k, int offset) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15160#discussion_r1284851860
