On Wed, 19 Jul 2023 07:07:40 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> I would like inputs on the > test/hotspot/jtreg/runtime/6294277/SourceDebugExtension.java test. That test > launches java passing it the -Xdebug option and was introduced as part of > https://bugs.openjdk.org/browse/JDK-6294277. -Xdebug has been a no-op for > many releases now. Is this test still relevant and if not, should I go ahead > and remove it as part of this change? The SDE class file attribute supports debugging of other languages (see JSR-45). The VM usually skips it but it has to save the bytes when a JVMTI agent has the can_get_source_debug_extension capability enabled. The debugger agent enables this capability so running with -agentlib:jdwp is enough to ensure that it is read. The -Xdebug option can be dropped from the test but otherwise I think leave it in place as it exercises a SDE that is >64k. ------------- PR Comment: https://git.openjdk.org/jdk/pull/14918#issuecomment-1641606804
