On Fri, 14 Jul 2023 06:43:15 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Bikeshed Trim log lines
>
> Test needs a fix for non-Linux.

Hi @dholmes-ora, @shipilev,

New version:

- added the log Aleksey suggested. Tested manually with +SafepointALot, works 
fine. Briefly considered making a patch out of it but did not since such a test 
is not reliable enough unless one runs a longer time, which I wanted to avoid.
- Discussion with David made me realize a status print function would be nice. 
Added said function. It is now called for hs_err file generation as well as in 
dcmd VM.info.
- I then used that function to beef up the gtest. I also now call the gtest 
(only the relevant os.trim... subsection) as a separate jtreg-controlled test.
- fixed the unsupported-platforms-case test

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14781#issuecomment-1635599120

Reply via email to