On Wed, 12 Jul 2023 18:48:42 GMT, Ashutosh Mehra <d...@openjdk.org> wrote:
>> Please review this PR that enables ClassWriter to write annotations to the >> class file being dumped. >> >> The fields annotations are stored in `Annotations::_fields_annotations` >> which is of type `Array<Array<u1>*>`. There is no class in SA that can >> represent it. I have added ArrayOfU1Array to correspond to the type >> `Array<Array<u1>*>` and it works. I believe there are better approaches but >> that would require a bit more refactoring of the classes representing Array >> types. I will leave that for future work for now. >> >> Testing: `test/hotspot/jtreg/serviceability/sa` and >> `test/jdk/sun/tools/jhsdb` >> Tested it manually by dumping j.l.String class and comparing the annotations >> with the original class using javap. >> The test case mentioned in >> [JDK-8311101](https://bugs.openjdk.org/browse/JDK-8311101) would provide >> better coverage. > > Ashutosh Mehra has updated the pull request incrementally with one additional > commit since the last revision: > > More review comments > > Signed-off-by: Ashutosh Mehra <asme...@redhat.com> Looks good, thanks! ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14735#pullrequestreview-1528442782
