On 3/07/2023 10:55 am, David Holmes wrote:
On Fri, 30 Jun 2023 13:10:06 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
Please review change for mostly fixing return types in the constant pool and metadata
to fix -Wconversion warnings in JVMTI code. The order of preference for changes are:
1. change the types to more distinct types (fields in the constant pool are u2
because that's their size in the classfile), 2. add direct int casts if the value has
been checked in asserts above, and 3. checked_cast<> if not verified, and 4.
added some pointer_delta_as_ints where needed.
Tested with tier1-4.
Coleen Phillimore has updated the pull request incrementally with one
additional commit since the last revision:
David's suggestions.
src/hotspot/share/runtime/jfieldIDWorkaround.hpp line 92:
90: result &= small_offset_mask; // cut off the hash bits
91: }
92: return result;
Doesn't this trigger a warning as we go from unsigned to signed?
Weird: I was sure I deleted this comment. Please ignore. I can't even
find it in the PR so responding via email.
David
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14710#discussion_r1249960932
