On Fri, 16 Jun 2023 11:52:51 GMT, Stefan Karlsson <stef...@openjdk.org> wrote:

> Generational ZGC changed the location where the heap object iterator called 
> the visit function. It used to be called when the objects were popped and 
> then followed, but it was changed so that the function where called 
> immediately when the objects are marked. This gave the benefit that the 
> verification code code show exactly what root had a broken object. 
> Unfortunately, this change started to apply non-GC closure during the root 
> iteration. This code lead to lock order issues, just like the one described 
> in the JBS entry.
> 
> This fix moves the visit calls for non-GC closures back to the follow calls.

Looks good.

-------------

Marked as reviewed by eosterlund (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14518#pullrequestreview-1483470046

Reply via email to