On Tue, 6 Jun 2023 22:34:33 GMT, Alex Menkov <amen...@openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   addressed new test related review comments
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadListStackTracesTest/ThreadListStackTracesTest.java
>  line 29:
> 
>> 27:  * @summary GetThreadListStackTraces returns wrong state for blocked 
>> VirtualThread
>> 28:  * @requires vm.continuations
>> 29:  * @modules java.base/java.lang:+open
> 
> I think `@modules` it's not needed

Thanks. Removed now.

> test/hotspot/jtreg/serviceability/jvmti/vthread/ThreadListStackTracesTest/ThreadListStackTracesTest.java
>  line 34:
> 
>> 32: 
>> 33: import java.util.concurrent.locks.ReentrantLock;
>> 34: import java.util.concurrent.*;
> 
> unused imports

Thanks. Removed now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14326#discussion_r1220495535
PR Review Comment: https://git.openjdk.org/jdk/pull/14326#discussion_r1220495047

Reply via email to