On Fri, 2 Jun 2023 10:19:53 GMT, JoKern65 <d...@openjdk.org> wrote: > This pr is a split off from JDK-8308288: Fix xlc17 clang warnings in shared > code https://github.com/openjdk/jdk/pull/14146 > It handles the part in security and servicability. > > Compiling on AIX with xlc17 which contains the new clang 15 frontend shows > the following warnings: > > src/java.security.jgss/share/native/libj2gss/NativeUtil.h:30: > src/java.security.jgss/share/native/libj2gss/gssapi.h:48:5: error: > 'TARGET_OS_MAC' is not defined, evaluates to 0 [-Werror,-Wundef] > #if TARGET_OS_MAC && (defined(ppc) || defined(ppc64) || defined(i386) || > defined(x86_64)) > ^ > TARGET_OS_MAC is not defined. Instead of disabling the warning, I could > ` #ifndef TARGET_OS_MAC` > `#define TARGET_OS_MAC=0` > `#endif` > But this is already handled by disabling the warning for gcc. > > src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c:718:33: error: > suggest braces around initialization of subobject [-Werror,-Wmissing-braces] > struct in6_addr mappedAny = IN6ADDR_ANY_INIT; > ^~~~~~~~~~~~~~~~ > /usr/include/netinet/in.h:454:32: note: expanded from macro 'IN6ADDR_ANY_INIT' > #define IN6ADDR_ANY_INIT {0, 0, 0, 0}
LGTM. ------------- Marked as reviewed by mdoerr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14282#pullrequestreview-1465140605
