On Tue, 6 Jun 2023 00:36:12 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java currently overrides
> the TestScaffold.startup() method:
>
> // override this to correct a bug so arguments can be passed to
> // the Target class
> protected void startUp(String targetName) {
> List<String> argList = new ArrayList<>(Arrays.asList(args));
> argList.add(0, targetName); // pre-pend so it becomes the first "app"
> arg
> println("run args: " + argList);
> connect((String[]) argList.toArray(args));
> waitForVMStart();
> }
>
> This issue of passing app args was fixed recently by
> [JDK-8308481](https://bugs.openjdk.org/browse/JDK-8308481), so the override
> is no longer needed.
Looks good in general.
The test is in the `test/jdk/ProblemList-Virtual.txt` marked with the bug
8285422 which very general. Is it a good time to remove it from the problem
list?
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14325#pullrequestreview-1464220984
