On Mon, 5 Jun 2023 21:55:02 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

> The test fails because it tries to determine the main debuggee thread by 
> allowing it run until the debuggee class is loaded (it waits for the 
> ClassPrepareEvent). Normally this would be done on the main debuggee thread. 
> However, when using virtual threads, the main thread has yet to spawn the 
> virtual thread to run the test on. The test is fixed by instead just waiting 
> until the debuggee main method is entered.
> 
> Tested by running the test locally with and without the virtual test thread 
> wrapper, and also all of tier1 plus tier5 svc tests.

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14322#pullrequestreview-1464181798

Reply via email to