On Wed, 31 May 2023 20:04:04 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 17 additional >> commits since the last revision: >> >> - Add impl note to document the XX option >> - Cleanup >> - Merge >> - Allow for warning to be skipped when same agent loaded a >> second/subsequent time >> - Merge >> - Tweak javadoc, update test to use more test infra >> - Merge >> - Merge >> - Refresh package description >> - Merge >> - ... and 7 more: https://git.openjdk.org/jdk/compare/09807c2a...2d9d5922 > > src/hotspot/share/prims/jvmtiAgent.cpp line 512: > >> 510: >> 511: // Print warning if EnableDynamicAgentLoading not enabled on the >> command line >> 512: if (!FLAG_IS_CMDLINE(EnableDynamicAgentLoading) && >> !agent->is_instrument_lib() && !JvmtiAgentList::is_loaded(library)) { > > While looking at some code related to this, I noticed a couple of typos in > the pre-existing load_agent_from_executable() comment. See lines 265 > ("cant't") and 268 (".&&"). Maybe you could clean them up. Nit: I'd suggest to add dot at the end of comment at 511. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13899#discussion_r1212499408
