On Tue, 23 May 2023 19:41:46 GMT, Frederic Parain <fpar...@openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fred's comments.
>
> src/hotspot/share/oops/constMethod.hpp line 453:
>
>> 451:
>> 452: // max stack
>> 453: int max_stack() const { return _max_stack; }
>
> max_stack() and max_locals() could return u2 instead of int.
Ok, yes they can since that would be consistant.
> src/hotspot/share/oops/klass.cpp line 264:
>
>> 262: super_check_cell = &_secondary_super_cache;
>> 263: }
>> 264: set_super_check_offset(u4((address)super_check_cell - (address)
>> this));
>
> The argument is cast to u4 but set_super_check_offset()'s declaration says
> that the argument should be a juint.
This casts the expression in the argument to u4 (same as juint), since the
address calculation returns 'address' which is 64 bits.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14092#discussion_r1204593679
PR Review Comment: https://git.openjdk.org/jdk/pull/14092#discussion_r1204593419
