On Fri, 19 May 2023 13:54:13 GMT, Paul Hohensee <p...@openjdk.org> wrote:

>> Please review this addition to com.sun.management.ThreadMXBean that returns 
>> the total number of bytes allocated on the Java heap since JVM launch by 
>> both terminated and live threads.
>> 
>> Because this PR adds a new interface method, I've updated the JMM_VERSION to 
>> 4, but would be happy to update it to 3_1 instead.
>
> Paul Hohensee has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   8304074: atomic load needed in exited_allocated_bytes

I'm happy with the basic implementation of this now - thanks. I'll leave any 
issues about spec and JMM version for serviceability folk to approve.

I will click Approve to get rid of the "requested changes" indicator but please 
wait for serviceability reviews.

-------------

PR Review: https://git.openjdk.org/jdk/pull/13814#pullrequestreview-1437782921
Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13814#pullrequestreview-1437784313

Reply via email to