> This is a follow-on to > [JDK-8308000](https://bugs.openjdk.org/browse/JDK-8308000) which adds JVMTI > PopFrames support for virtual thread. For JDWP and JDI this is mostly a spec > update, although JDI needs minor changes to properly throw the correct > exception. Note this PR needs JDK-8264699 in order to function properly, so > there may be some GHA failures until JDK-8308000 is pushed. > > There are a large number of tests that can now be removed from the problem > list. Also, one test needs to be modified to no longer expect > OpaqueFrameException for virtual threads. It was just revereted back to it's > previous form before the OpaqueFrameException support was added for virtual > threads. > > As you can see from the problemlist update, there are quite a few tests for > popFrames() support. However, there are still two coverage gaps: > > - There is no test for throwing NativeMethodException (even for platform > threads) > - There is no test case for throwing OpaqueFrameException when the virtual > thread is suspended but not mounted. > > I may eventually add one or both tests to the PR, or I may just file separate > CRs for them for now.
Chris Plummer has updated the pull request incrementally with three additional commits since the last revision: - Test cases for ThreadReference.popFrames() - Fix for JDK-8308481 (add app arg support to TestScaffold). I need it for the test case I'm going to commit. - Make sure we also check if previous frame is native. ------------- Changes: - all: https://git.openjdk.org/jdk/pull/14022/files - new: https://git.openjdk.org/jdk/pull/14022/files/b3000dca..508eec13 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=14022&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14022&range=01-02 Stats: 459 lines in 4 files changed: 442 ins; 0 del; 17 mod Patch: https://git.openjdk.org/jdk/pull/14022.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14022/head:pull/14022 PR: https://git.openjdk.org/jdk/pull/14022
