On Mon, 15 May 2023 02:16:43 GMT, Yi Yang <yy...@openjdk.org> wrote: >> Yi Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> execute VM_HeapDumper directly > > Hi, can I have a review for this patch?
> @y1yang0 Sorry no one has been able to review this so far. The serviceability > team is very busy for the next few weeks finishing up JDK 21 changes before > RDP1. It's unlikely we'll find time for the review before them. > > I did take a very quick look at the changes just to understand the scope. One > thing I noticed that makes this PR hard to review is the code refactoring and > relocating that you did. At first it looks like a lot of old code was deleted > and a lot of new code added, but in fact most of the new code is just > relocated old code. It makes it very hard to tell if there have been any > changes to this code. Is there anything you can do to lessen the amount of > apparent new code that is actually just moved code? Hi @plummercj Thanks for your heads-up, I saw RPD1 ends at 06/08, I will ping everyone again in mid June and hope to have reviews when you have time. The refactoring is necessary because - All related code about ParDumpWriter is unused after this patch - In `heapDumperCompression` file, most of the code is used for writing heap dump rather than compression(after applying this patch). Therefore, I renamed it to `heapDumperWriter`. However, considering that this may make the review process difficult, I will revert this change and keep the original file name for now. When the review process reaches a proper time point, I will rename it again. ------------- PR Comment: https://git.openjdk.org/jdk/pull/13667#issuecomment-1551031432
