On Mon, 15 May 2023 23:07:20 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> excluded 1 more test after testing > > test/lib/jdk/test/lib/process/ProcessTools.java line 402: > >> 400: final List<String> unsupportedArgs = List.of( >> 401: "-jar", "-cp", "-classpath", "--class-path", >> "--describe-module", "-d", >> 402: "--dry-run", "--list-modules","--validate-modules", "-m", >> "--module", "-version"); > > Can you fix the indentation on line 398 above? It doesn't seem to make much sense to have an argument be in both `unsupportedArgs` and `doubleWordArgs`. `unsupportedArgs` seems to take precedence and the arg will never have a change to be found in `doubleWordArgs`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13968#discussion_r1194445040
