On Mon, 15 May 2023 22:18:32 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> Looks good to me. >> Please update "@summary" statement about "notKilled" (now "killed") field > > I went to edit the PR description, but found it is not actually incorrect. It > says "kill001 suspends all threads at a breakpoint". That is actually true. > Although it is the main thread that hits the breakpoint, all threads are > suspended. Since the additional threads are suspended and mounted, the > TR.stop() can be done on them. If they are blocked (as they are) but not > suspended, the TR.stop() would fail (for virtual threads). I'll try to clean > it up a bit though. The description could be clearer. Yes, I realized this too. By default breakpoints have SUSPEND_ALL policy. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13967#discussion_r1194440468
