On Thu, 11 May 2023 16:03:54 GMT, Poonam Bajaj <poo...@openjdk.org> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> use backslash for directory separator. some additional clarifications. > > src/jdk.hotspot.agent/doc/transported_core.html line 90: > >> 88: >> 89: <p> >> 90: By default symbols are also located using <b>PATH</b>. However, there >> are also Java properties that can be used to specify both the location of >> the binaries, and also separately the location of symbols. Use >> <b>sun.jvm.hotspot.debugger.windbg.imagePath</b> for the location of >> binaries, and use <b>sun.jvm.hotspot.debugger.windbg.symbolPath</b> for the >> location of symbols. <b>imagePath</b> defaults to <b>PATH</b> if not set, >> and <b>symbolPath</b> defaults to <b>imagePath</b>. The advantage of using >> these propeties is that you don't need to change your <b>PATH</b> setting, >> and they allow for binaries to be located separately from symbols. > > Is "also" needed here? The sentence makes more sense without it. The "also" is in reference to the previous paragraph mentioning that binaries are located using PATH. In other words, PATH is by default used to locate binaries and also to locate symbols. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13849#discussion_r1191476669
