On Thu, 4 May 2023 19:35:58 GMT, Daniel D. Daugherty <dcu...@openjdk.org> wrote:
>> Roman Kennke has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address @dholmes-ora's review comments > > src/hotspot/share/runtime/lockStack.inline.hpp line 53: > >> 51: bool is_owning = &JavaThread::cast(thread)->lock_stack() == this; >> 52: assert(is_owning == (get_thread() == thread), "is_owning sanity"); >> 53: return is_owning; > > This is going to require a re-test just to make sure that we don't have > a code path into here from the VMThread when it is doing some > JVM/TI stuff (again...). I don't think so. That code did use JavaThread::cast(thread) before which would have fired. But that means I can leave out the JavaThread::cast() now. Let me do that change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/10907#discussion_r1185508726