On Fri, 5 May 2023 05:48:04 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> JNI local reporting uses this tricky _is_top_frame/_last_entry_frame stuff >> I think it would be better to have it in the main do_frame method for better >> readability > > Sorry, I do not see how this improves readability. > Big functions with many layered conditions do not improve readability. I mean the pieces of the code that set and use _is_top_frame/_last_entry_frame are close so it's easier to see the logic ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1186539125
