On Wed, 3 May 2023 00:14:50 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fixed main.wrapper property usage.
>
> test/hotspot/jtreg/vmTestbase/nsk/share/MainWrapper.java line 50:
> 
>> 48: 
>> 49:         // Some tests use this property to understand if virtual threads 
>> are used
>> 50:         System.setProperty("main.wrapper", "Virtual");
> 
> Shouldn't this be:
> 
> `System.setProperty("main.wrapper", wrapperName);`

Thanks, better to use wrapperName as a well as to set it it in TestScaffold.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13763#discussion_r1183199536

Reply via email to