On Mon, 1 May 2023 17:02:04 GMT, Patricio Chilano Mateo <pchilanom...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Merge branch 'br29' of https://github.com/sspitsyn/jdk into br29 >> merge with branch29 >> - move code a little bit > > src/hotspot/share/runtime/sharedRuntime.cpp line 639: > >> 637: JRT_END >> 638: >> 639: JRT_ENTRY(void, SharedRuntime::notify_jvmti_vthread_start(oopDesc* vt, >> jboolean dummy, JavaThread* current)) > > Maybe rename dummy to hide and just assert is false in this case and true for > the vthread_end case? Good suggestion. Thank you. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13484#discussion_r1181893509
