On Wed, 26 Apr 2023 18:58:13 GMT, Roman Kennke <rken...@openjdk.org> wrote:
>>> @rkennke - I'm planning to do another crawl thru review next week. >> >> Thanks! That is greatly appeciated! > >> @rkennke - finished my second crawl thru review of 60/68 files changed. I >> only skipped the RISC-V files since I know nada about that platform... >> >> My Mach5 testing of v61 is running Tier7 and I hope to start Tier8 later >> tonight. So far all testing looks good, but I'll include the usual summary >> comment in the bug report... > > Thanks so much for reviewing this large PR (so many times)! I believe I have > incorporated all your suggestions (or left a comment/question when it wasn't > clear). > > Cheers, > Roman @rkennke Last ARM32 fixes: https://gist.github.com/tstuefe/8a0fd30618f1d0e085b5ca12d7c156cd I removed the superfluous flush from sharedRuntime. For a test, I applied https://github.com/openjdk/jdk/pull/13596 patch and built and tested arm (starting fastlockbench with interpreted, c1, c2), all seems to be well. ------------- PR Comment: https://git.openjdk.org/jdk/pull/10907#issuecomment-1527233512
