On Thu, 27 Apr 2023 17:42:41 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> Convert this ThreadReference.interrupt() test to support virtual threads. I
> believe this is the only test for ThreadReference.interrupt() that we have.
>
> Tested by running with and without -Dmain.wrapper=Virtual on all supported
> platforms.
Changes requested by lmesnik (Reviewer).
test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001a.java
line 209:
> 207: }
> 208:
> 209: class interrupt001aThread implements Runnable {
Does it make sense to rename class to something like Interrupt001aTask? Just to
let know that it is not a thread. Also, there is ./nsk/share/jdi/NamedTask.java
for task with names in JDI tests.
-------------
PR Review: https://git.openjdk.org/jdk/pull/13696#pullrequestreview-1404771083
PR Review Comment: https://git.openjdk.org/jdk/pull/13696#discussion_r1179608600
