On Thu, 20 Apr 2023 02:46:58 GMT, Leonid Mesnik <lmes...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressed review comments on new test > > test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java > line 48: > >> 46: static final int JVMTI_ERROR_NONE = 0; >> 47: static final int THREAD_NOT_SUSPENDED = 13; >> 48: static final int PASSED = 0; > > I think it would be better to don't use statuses and just throw exception > after first failure. Usually the other results of other test cases might be > corrupted and output just confuse user. I've made some changes to throw RuntimeException right away in the Main thread. However, this status is still needed for failures from the TestTask thread. Sync protocol with the TestTask thread needs to remain. Otherwise, the process hangs. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13546#discussion_r1172847943
