On Thu, 23 Mar 2023 08:36:59 GMT, Erik Österlund <eosterl...@openjdk.org> wrote:
>> The best alternative to me is to take the perf hit and disable the caching >> when we're in forte (possibly only on Mac). > >> The best alternative to me is to take the perf hit and disable the caching >> when we're in forte (possibly only on Mac). > > Sounds like a plan. > Reading @fisk excellent catch the async safety of stacking the wx raii > mechanics, I retract my approval. This looks like a recipe for hard-to-find > bugs :-/ Yes, this is my current thought too. > Incidentally, do we see in the hs_err file whether async profiler is > attached? We should maybe make that prominently visible. We see ASGCT in the stack trace, but what exactly do you mean. > I feel there are information missing :) But would you be okay with disabling the cache modification if the perf impact is low? ------------- PR Comment: https://git.openjdk.org/jdk/pull/13144#issuecomment-1480883378
