On Thu, 23 Mar 2023 05:43:35 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.hpp line 87: >> >>> 85: >>> 86: static bool enable_virtual_threads_notify_jvmti(); >>> 87: static bool disable_virtual_threads_notify_jvmti(); >> >> "disable" only seems to be used by the WB API. Is that expected? > > Yes, this is from the PR description: >> New function JvmtiEnvBase::disable_virtual_threads_notify_jvmti() which is >> needed for testing. >> It is used by the WhiteBox API. > > Do you think a comment is needed? I was wondering why we would be testing something that can't ever be triggered by a regular java program. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1145716490
