On Sat, 4 Mar 2023 06:29:20 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
> Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14, and Microsoft Virtual Studio, because > of security concerns. The issue was addressed in > [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building > failure, and > [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378)/[JDK-8299635](https://bugs.openjdk.org/browse/JDK-8299635)/[JDK-8301132](https://bugs.openjdk.org/browse/JDK-8301132) > for testing issues . This is a break-down update for sprintf uses in > jdk.jdwp.agent module. > > Thanks, > Xuelei Copyright needs updating. src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 224: > 222: b[received] = '\0'; > 223: /* > 224: * We should really use snprintf here but it's not available on > Windows. This Windows comment should be removed. You can probably get rid of the jio_snprintf comment below as well since it adds little value, and doesn't make sense to just mention it here and not elsewhere. ------------- Changes requested by cjplummer (Reviewer). PR: https://git.openjdk.org/jdk/pull/12870
