On Sun, 26 Feb 2023 21:02:43 GMT, Christoph Langer <clan...@openjdk.org> wrote:
> PS I guess you should update the copyright year before pushing. Ah right, thanks for the reminder > > @RealCLanger Sorry for the ping, just wanted to check since you're the > > original commit Author for the format string, is there someplace else where > > inttypes.h or stdint.h is included or should be included that I missed? > > Hah, that was a long time ago. 😄 I think this change is fine - and I'm not > aware of other places. But that doesn't mean a lot. 😉 I see haha, I was just worried since that's what the ifdef implied. Strange that the check was a `#ifdef _WIN32` though since this is Windows only code (in fact I'm wondering why this file and the others in the same directory as it is in shared native code at all) ------------- PR: https://git.openjdk.org/jdk/pull/12744
