On Fri, 17 Feb 2023 17:28:19 GMT, Alan Bateman <al...@openjdk.org> wrote:

> Thanks for dropping is_bound_vthread, I think it's much better now. What 
> would you think about changing it to test the thread type is_a 
> vmClasses::BaseVirtualThread_klass() so the VM doesn't need to know about 
> ThreadBuilders$BoundVirtualThread.
>
Yes, we could do that. Although I think that checking for 
BoundVirtualThread_klass is more descriptive of what we are trying to do and 
will be less confusing when reading the code. How about checking for 
`(!VMContinuations && x->is_a(vmClasses::BaseVirtualThread_klass()))`?

-------------

PR: https://git.openjdk.org/jdk/pull/12512

Reply via email to