On Mon, 30 Jan 2023 20:24:16 GMT, Serguei Spitsyn <sspit...@openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with two additional 
>> commits since the last revision:
>> 
>>  - filter properties update: more classes logged as ALLOWED during wider 
>> testing
>>  - Add a Notification test
>
> test/jdk/javax/management/remote/mandatory/connection/DefaultAgentFilterTest.java
>  line 150:
> 
>> 148:             String description = "An attribute of this MBean has 
>> changed";
>> 149:             MBeanNotificationInfo info = new 
>> MBeanNotificationInfo(types, name, description);
>> 150:             return new MBeanNotificationInfo[] {info};
> 
> Nit: It can be useful to print that this method was invoked the same as in 
> other methods.

got it

-------------

PR: https://git.openjdk.org/jdk20/pull/97

Reply via email to