On Fri, 27 Jan 2023 23:39:11 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
> Thanks for cleaning this up. The changes look good. Did you experiment with > any of the tests to make sure an invalid arg passed to the debuggee results > in a failure? You can add the arg to the start of `-debugee.vmkeys` in > TestDescriptions.java. Yes, test fails with # ERROR: ##> debugger: ERROR: Exception : nsk.share.Failure: Caught exception while starting debugee VM: # ERROR: com.sun.jdi.connect.VMStartException: VM initialization failed for: /home/lmesnik/ws/jdk-jdi/build/linux-x64/images/jdk/bin/java -XX:MaxRAMPercentage=1.5625 -Dtest.boot.jdk=/var/tmp/jib-lmesnik/install/jdk/19/36/bundles/linux-x64/jdk-19_l inux-x64_bin.tar.gz/jdk-19 -Djava.io.tmpdir=/home/lmesnik/ws/jdk-jdi/build/linux-x64/test-support/jtreg_open_test_hotspot_jtreg_vmTestbase_nsk_jdi_DoubleType_itself_doubletype001_TestDescription_java/tmp -XX:NONE -Xdebug -Xrunjdwp:transport=dt_socket,add ress=localhost:48711,suspend=y,includevirtualthreads=y nsk.jdi.DoubleType._itself_.doubletype001a -vbs -verbose -arch=linux-x64 -waittime=5 -debugee.vmkind=java -transport.address=dynamic -debugee.vmkeys="-XX:MaxRAMPercentage=1.5625 -Dtest.boot.jdk=/var/ tmp/jib-lmesnik/install/jdk/19/36/bundles/linux-x64/jdk-19_linux-x64_bin.tar.gz/jdk-19 -Djava.io.tmpdir=/home/lmesnik/ws/jdk-jdi/build/linux-x64/test-support/jtreg_open_test_hotspot_jtreg_vmTestbase_nsk_jdi_DoubleType_itself_doubletype001_TestDescription _java/tmp -XX:NONE" -pipe.port=43001 # ERROR: stdout: # ERROR: stderr: Unrecognized VM option 'NONE' # ERROR: Error: Could not create the Java Virtual Machine. # ERROR: Error: A fatal exception has occurred. Program will exit. ------------- PR: https://git.openjdk.org/jdk/pull/12270
