On Tue, 24 Jan 2023 22:49:20 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> This change was made because it was compared to the original >> messages.properties. In that file, the respective line is given as >> `MANAGE_HOTSPOT_MBEANS_IN_COLON_=Manage Hotspot MBeans in:` with no trailing >> space. That's why in this file, to ensure consistency, the trailing space >> was stripped. >> >> I think either this space should be removed, or all 4 (en, ja, de, zh) >> should have the `\u0020` appended. I agree that since it is a prefix it >> would make sense for a space to be there, but there is no guarantee that >> what comes after, or even the code that loads the .properties file does not >> already handles that necessary space. >> >> Should the space remain removed like in the English source file and the >> other l10n files, or do you think all 4 should be changed to add `\u0020`? > > Confirmed that the message is for a label > (`sun.tools.jconsole.LabeledComponent`), followed by a Component, so no space > seems needed in each file. Sorry for the false alarm. Ok I left this change out of my most recent update just in case. I addressed all the other comments I believe. Thanks! ------------- PR: https://git.openjdk.org/jdk20/pull/116
