On Thu, 19 Jan 2023 18:54:08 GMT, Xue-Lei Andrew Fan <xue...@openjdk.org> wrote:
>> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for hotspot impl, >> and [JDK-8299378](https://bugs.openjdk.org/browse/JDK-8299378) for building, >> but the test case was not covered. The failure was reported in [PR >> 11793](https://github.com/openjdk/jdk/pull/11793#issuecomment-1371151565), >> while running tier1 testing. >> >> This patch is trying to find the use of sprintf in hotspot iml and test >> cases. > > Xue-Lei Andrew Fan has updated the pull request incrementally with two > additional commits since the last revision: > > - remove serviceability update and add back forbid of sprintf > - remove serviceability update I was (still) puzzled by the remaining sprintf:s in the JDK and the fact that the build completed successfully even if not all of them had been address/updated, so I investigated it a bit and came to the conclusion that the Xcode/clang warning (which we turn into an error with `-Werror`) only seems to be generated for C++ files, not for C files. For many reasons we may still want to fix the remaining occurrences as well, but for the immediate case of the new Xcode version it seems to be sufficient to fix the C++ files. ------------- PR: https://git.openjdk.org/jdk/pull/11935
