On Tue, 17 Jan 2023 20:50:26 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:
>> src/hotspot/os/windows/os_windows.cpp line 387: >> >>> 385: os::snprintf_checked(buf, sizeof(buf), "%s%s;%s%s%s", >>> 386: Arguments::get_java_home(), EXT_DIR, >>> 387: path, PACKAGE_DIR, EXT_DIR); >> >> When the call is split across multiple lines like this, the subsequent lines >> should align with the first parameter i.e. align under `buf`. > > I think the other acceptable approach is to put the first argument on the 2nd > line, and then indent all the argument lines by 8. That works well if the > first argument would otherwise start too far to the right. For the above, I > think either approach would look ok. I can see both styles are used in this file. The current code here uses 8 whitespaces indent, I would like to keep it. ------------- PR: https://git.openjdk.org/jdk/pull/11935
