On Wed, 18 Jan 2023 12:22:01 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve link target per code review comments.
>
> src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java
> line 140:
>
>> 138: * implementation may choose to find providers by other means. For
>> 139: * example, it may support {@linkplain
>> 140: * java.base/java.util.ServiceLoader##developing-service-providers
>> service providers},
>
> is `java.base/` needed here? I am a bit surprised - it's first time I see a
> module name used in a regular link target.
Updated.
> src/java.management/share/classes/javax/management/remote/JMXConnectorServerFactory.java
> line 129:
>
>> 127: * <code>MalformedURLException</code> if there is none. An
>> 128: * implementation may choose to find providers by other means. For
>> 129: * example, it may support {@linkplain
>
> Same remark regarding `java.base/` prefix.
For the connector server factory, "java.util" is still needed in the link since
I didn't want to change the import statements of the class.
-------------
PR: https://git.openjdk.org/jdk/pull/12058
