On Tue, 10 Jan 2023 22:50:11 GMT, Justin King <jck...@openjdk.org> wrote:
>> Remove abstraction that is a holdover from Solaris. Direct usages of >> `MmapArrayAllocator` have been switched to normal `malloc`. The >> justification is that none of the code paths are called from signal >> handlers, so using `mmap` directly does not make sense and is potentially >> slower than going through `malloc` which can potentially re-use memory >> without making any system calls. The remaining usages of `ArrayAllocator` >> and `MallocArrayAllocator` are equivalent. > > Justin King has updated the pull request incrementally with one additional > commit since the last revision: > > Initialize memory to zero in zGranuleMap > > Signed-off-by: Justin King <jck...@google.com> I'm happy to see this flag getting removed. I'm less happy about seeing usages of the array allocators being replaced by macros. I'd rather see an effort towards getting rid of these macros. Could we limit this patch to only remove the ArrayAllocatorMallocLimit flag and ArrayAllocator class, and defer the discussion around what API to use for array allocations? ------------- PR: https://git.openjdk.org/jdk/pull/11931
