On Wed, 4 Jan 2023 12:56:18 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Please review this patch that removes the remaining uses of non-reentrant > `getprotobyname` function. > > While the protocol number for TCP could theoretically be modified to > something other than the default `IPPROTO_TCP`, that scenario would likely > not work, and is not something that we are willing to support. [Existing > code](https://github.com/openjdk/jdk/blob/2f3f3b618500b5f112fabca30d4c6780b2a8e723/src/java.base/unix/native/libnet/net_util_md.c#L355) > in networking area is using `IPPROTO_TCP` for `TCP_NODELAY`, and no issues > were reported. > > Tier 1-3 tests still pass. This pull request has now been integrated. Changeset: d03a5d95 Author: Daniel Jeliński <djelin...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/d03a5d9580ef3b9be4d766ff9a11d6fd5fa133f9 Stats: 8 lines in 2 files changed: 0 ins; 4 del; 4 mod 8299593: getprotobyname should not be used Reviewed-by: cjplummer ------------- PR: https://git.openjdk.org/jdk/pull/11842