On Fri, 18 Nov 2022 19:34:19 GMT, Chris Plummer <cjplum...@openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   ajust condition when init_static_notify_jvmti_events() is called
>
> src/hotspot/share/prims/jvmtiExport.cpp line 390:
> 
>> 388:       java_lang_VirtualThread::init_static_notify_jvmti_events();
>> 389:     }
>> 390:   }
> 
> Yes, this looks good now. Removing the `if (!java_lang_VirtualThread 
> ::notify_jvmti_events())` check means the `init_static_notify_jvmti_events()` 
> can still be called on subsequent calls to this method. So if 
> `init_static_notify_jvmti_events()` was not called the first time (due to not 
> being in the LIVE phase), then it can still be called on subsequent calls to 
> this method if not in the LIVE phase.

Okay. Thank you for the review, Chris,

-------------

PR: https://git.openjdk.org/jdk/pull/11204

Reply via email to