On Mon, 7 Nov 2022 19:23:05 GMT, Bill Huang <bhu...@openjdk.org> wrote:

> There is no new changes in the open portion of JDK, but extracting common 
> functionalities in bootstrap Utils to test/lib/Utils which can be used in the 
> closed part.

The refactoring looks pretty good.
But I have a couple of questions.
Q1: The method `grantAccess` is converted to the util method `grantFileAccess` 
and it does not look the same. Could you, please, explain what are the changes?
Q2: I'm confused about conversion of the shell tests. Your fix does not convert 
any shell test. Also, I do not see any changes to the shell ile 
`test/jdk/sun/management/jmxremote/bootstrap/ReadWriteForbidsCreateTest.sh` 
listed in the enhancement. Can you explain, please?

-------------

PR: https://git.openjdk.org/jdk/pull/11029

Reply via email to