On Tue, 13 Sep 2022 13:29:45 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
> I moved misc_flags out to their own misc flags class so that we can put the > writeable accessFlags there too with atomic access. > > Tested with tier1-4. Refactoring looks good. These are all the immutable flags right? (ie set once during class creation, and no concurrency issues). One query on SA below. Thanks. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java line 129: > 127: > 128: MISC_REWRITTEN = > db.lookupIntConstant("InstanceKlass::_misc_rewritten").intValue(); > 129: MISC_HAS_NONSTATIC_FIELDS = > db.lookupIntConstant("InstanceKlass::_misc_has_nonstatic_fields").intValue(); These all seem to have been deleted rather than modified ?? ------------- Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.org/jdk/pull/10249