On Fri, 7 Oct 2022 19:54:54 GMT, Kevin Walls <kev...@openjdk.org> wrote:
> There are a few changes we can make to better understand the LingeredApp test > when it goes wrong: > > startAppExactJvmOpts() should not try and call finishApp unless the process > isAlive, that just creates a misleading exception. > > waitAppReady() is really waitAppReadyOrCrashed(), and should not timeout > immediately after the 1 second sleep, or we lose a second of our timeout > value (not critical with a long timeout, but seems more honest). > > Show how long we waited when startup/crashing times out. > > Show how long a good startup takes, so we have a basic for comparison when it > fails. > > Show if there are hs_err/core/mdmp files in the working directory after > startup/crash attempt. > > Also, in open/test/lib/jdk/test/lib/util/CoreUtils.java: > > "Move core file" often seems unnecessary, core/mdmp usually being created in > the current directory. But getCoreFileLocation() performs Files.move() which > takes enough time to not be a no-op. This pull request has now been integrated. Changeset: 9051dded Author: Kevin Walls <kev...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/9051dded84ef2d248483a6a1472def1eab79654f Stats: 59 lines in 2 files changed: 39 ins; 5 del; 15 mod 8294993: LingeredApp test update Reviewed-by: cjplummer, amenkov ------------- PR: https://git.openjdk.org/jdk/pull/10613
